rename silvercrest and nexus to mitigate codebase conflict with ESPiL… #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tks for the effort, but as the files are a direct copy from rtl_433_ESP, I don't want to make changes to them, that will be overwritten but the next port. |
|
The changes could be proposed upstream in rtl_433 repository. |
|
Thanks for the feedback to both of you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hit the problem with codebase conflict, then saw the remark in the README.
With this change openmqttgateway compiles without warning. However i am not confident the changes are functional ok. What is your opinion?