Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cor 484 scopes n claims #407

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Cor 484 scopes n claims #407

wants to merge 8 commits into from

Conversation

internetti
Copy link
Member

@internetti internetti commented May 18, 2022

COR-484

thought it would be a good idea to increment the version automatically, but the way this is represented in the authnz frontend is not ideal yet

@rational-terraforming-golem
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: internetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cmd/devinit/main.go Outdated Show resolved Hide resolved
@ludydoo
Copy link
Contributor

ludydoo commented May 18, 2022

I think that we do not need the Scan or Value methods in the api package, since those methods are only called by the database driver to convert to and from a value that comes from and to the database!

@internetti
Copy link
Member Author

I think that we do not need the Scan or Value methods in the api package, since those methods are only called by the database driver to convert to and from a value that comes from and to the database!

the Value method seems to be needed there, if it's missing, the update fails with cannot convert {6 map[a:b]} to Bytea

@rational-terraforming-golem
Copy link
Contributor

@internetti: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ludydoo
Copy link
Contributor

ludydoo commented May 18, 2022

I think that's because we don't convert from the api types to the store types... Because only 1 of these need to be converted to/from the database. I can check with you tomorrow perhaps ?

ludydoo and others added 2 commits June 1, 2022 10:42
Remove `Valuer` implementation from `api/types`
@rational-terraforming-golem
Copy link
Contributor

@internetti: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants