Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pretty_midi instead of an internal fork #6

Closed
roszcz opened this issue Sep 25, 2024 · 0 comments · Fixed by #7
Closed

Use pretty_midi instead of an internal fork #6

roszcz opened this issue Sep 25, 2024 · 0 comments · Fixed by #7

Comments

@roszcz
Copy link
Member

roszcz commented Sep 25, 2024 •
edited
Loading

We should revert #5 - Pretty MIDI is in active development, and we do not need any custom modifications, so it's better to rely on the external package, than to manage all its code internally.
@roszcz roszcz linked a pull request Sep 25, 2024 that will close this issue
Reimplement MidiFile with pretty_midi #7
Merged
2 tasks
@roszcz roszcz closed this as completed in #7 Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reimplement MidiFile with pretty_midi Nospoko/fortepyan
1 participant
@roszcz