Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement MidiFile with pretty_midi #7

Merged
merged 8 commits into from
Sep 27, 2024
Merged

Reimplement MidiFile with pretty_midi #7

merged 8 commits into from
Sep 27, 2024

Conversation

roszcz
Copy link
Member

@roszcz roszcz commented Sep 25, 2024 •
edited
Loading

  • use pretty_midi from pypi instead of internal copy
  • add merge_files to MidiFile interface

To test midi file merging:

pip install -e .[dev]
PYTHONPATH=. streamlit run dashboards/merge_files.py
image

@roszcz roszcz linked an issue Sep 25, 2024 that may be closed by this pull request
Use pretty_midi instead of an internal fork #6
Closed
@roszcz roszcz changed the title Reimplement MidiFile with pretty_midi, update tests Reimplement MidiFile with pretty_midi Sep 25, 2024
@roszcz roszcz force-pushed the 6-use-pretty_midi-instead-of-an-internal-fork branch from cabf52b to 4bf0991 Compare September 27, 2024 06:40
@roszcz roszcz linked an issue Sep 27, 2024 that may be closed by this pull request
Add support for merging multiple MidiFiles into one #8
Closed
@roszcz roszcz self-assigned this Sep 27, 2024
@roszcz roszcz merged commit 98b7f57 into develop Sep 27, 2024
3 checks passed
@roszcz roszcz deleted the 6-use-pretty_midi-instead-of-an-internal-fork branch September 27, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@roszcz roszcz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for merging multiple MidiFiles into one Use pretty_midi instead of an internal fork
1 participant
@roszcz