Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated event collection to ODM #5

Open
wants to merge 2 commits into
base: feat/beanie-odm/master
Choose a base branch
from

Conversation

Nydauron
Copy link
Owner

To be merged into staging feature branch feat/beanie-odm/master

Description

Migrates over event collection references to use Beanie ODM

Checks

  • I ran black over the code to ensure formatting.
  • I added docstrings to any new modules, classes, and methods.
  • I updated the docstrings of any updated modules, classes, and methods.
  • I added/updated Python typings for any new/updated class and module.
  • I updated the bot version (if necessary).
  • I ran mypy and reviewed any shown errors related to my changes.

Important Info

  • This pull request adds new pip dependencies.
  • This pull request adds new external dependencies.
  • This pull request changes the required versions of some dependencies.

Issues Closed

My pull request closes the following issues:

  • N/A

Thank You

Thank you for your contribution to Scioly.org! This pull request will be reviewed
in a promptly manner. If not done, please feel free to contact @cbrxyz.

@Nydauron Nydauron force-pushed the feat/beanie-odm/events branch 2 times, most recently from d7464dd to ac1d33f Compare May 31, 2024 20:12

# Check to see if role exists on server
server = self.bot.get_guild(env.server_id)
potential_role = discord.utils.get(server.roles, name=event_name)

if event_not_in_list and potential_role:
Copy link
Owner Author

@Nydauron Nydauron Jun 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this was supposed to be event_not_in_list and not potential_role given the comment below it was:

# If no event in list and no role exists on server

Otherwise, there would be no way for partially deleted events (i.e. events that were deleted from the db but had their roles available) to be fully deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant