Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create user object and user endpoint #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xurror
Copy link

@xurror xurror commented May 13, 2020

No description provided.

@xurror
Copy link
Author

xurror commented May 13, 2020

@maektwain please can you have a look at this.

Copy link

@maektwain maektwain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add the user in top level object

Copy link

@maektwain maektwain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, nice work did you get the chance to run this and test it also?

@maektwain
Copy link

@m0rphtail could you do a dry run with the above changes? I mean test it

@maektwain
Copy link

Have you tested this @xurror ?

@xurror
Copy link
Author

xurror commented May 18, 2020 via email

@maektwain
Copy link

So we might need to test this before we go ahead with these changes. Maybe that could be something you might want to do this? Maybe using via the wallet client to make things easier.

@xurror
Copy link
Author

xurror commented May 20, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants