-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create user object and user endpoint #10
base: master
Are you sure you want to change the base?
Conversation
@maektwain please can you have a look at this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add the user in top level object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, nice work did you get the chance to run this and test it also?
@m0rphtail could you do a dry run with the above changes? I mean test it |
Have you tested this @xurror ? |
Unfortunately no, I could not run proper tests on a secured endpoint. There
are some request header params I'm not able to set up
|
So we might need to test this before we go ahead with these changes. Maybe that could be something you might want to do this? Maybe using via the wallet client to make things easier. |
Yes, I fear I will have to do that.
…On Tue, 19 May 2020 at 18:05, Maek Twain ***@***.***> wrote:
So we might need to test this before we go ahead with these changes. Maybe
that could be something you might want to do this? Maybe using via the
wallet client to make things easier.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK5B5DDAZVMY62A2XCMAOHLRSK36TANCNFSM4NAD2DDQ>
.
|
No description provided.