Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] account_invoice_tax_required #1259

Merged
merged 47 commits into from
Oct 15, 2022

Conversation

ThomasBinsfeld
Copy link
Contributor

vrenaville and others added 30 commits October 10, 2022 11:21
Currently translated at 100,0% (4 of 4 strings)

Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_tax_required
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_tax_required/es/
Currently translated at 100,0% (4 of 4 strings)

Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_tax_required
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_tax_required/de/
Using `invoice_validate` method for validating invoice, makes the call to the sequence
to be done before, and although rollbacking the transaction, the next number is already
assigned and then you may have gaps in your numbering.

Thus, we do the check before this, on the first executed method.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_tax_required
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_tax_required/
oca-transbot and others added 4 commits October 10, 2022 11:21
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-15.0/account-invoicing-15.0-account_invoice_tax_required
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_invoice_tax_required/
Currently translated at 100.0% (4 of 4 strings)

Translation: account-invoicing-15.0/account-invoicing-15.0-account_invoice_tax_required
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_invoice_tax_required/ca/
@oca-clabot
Copy link

Hey @ThomasBinsfeld, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

dict(
code="cust_acc",
name="customer account",
user_type_id=account_user_type.id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
user_type_id=account_user_type.id,
account_type="asset_receivable",

"account_id": self.account_account.search(
[
(
"user_type_id",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"user_type_id",
"account_type",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

(
"user_type_id",
"=",
self.env.ref("account.data_account_type_revenue").id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.env.ref("account.data_account_type_revenue").id,
"income",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@OCA OCA deleted a comment from OCA-git-bot Oct 10, 2022
@adrienpeiffer
Copy link
Contributor

/ocabot migration account_invoice_tax_required

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 10, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 10, 2022
64 tasks
@ThomasBinsfeld ThomasBinsfeld force-pushed the 16.0-mig_account_invoice_tax_required_tbi branch from aeebfb8 to b1aa18c Compare October 10, 2022 09:52
Copy link
Contributor

@adrienpeiffer adrienpeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test and Code review

Copy link

@AnizR AnizR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@kittiu
Copy link
Member

kittiu commented Oct 11, 2022

/ocabot migration account_invoice_tax_required

@adrienpeiffer not related to this PR, I just miss this ocabot migration feature, can you guide where I can find info about this? Thanks! :)

@adrienpeiffer
Copy link
Contributor

@kittiu https://github.com/OCA/oca-github-bot#readme

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1259-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3dbc298 into OCA:16.0 Oct 15, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 35134d9. Thanks a lot for contributing to OCA. ❤️

odooNextev pushed a commit to odooNextev/account-invoicing that referenced this pull request Sep 29, 2023
Signed-off-by HaraldPanten
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.