Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] account_invoice_fixed_discount: Division by zero #1680

Conversation

ioans73
Copy link
Member

@ioans73 ioans73 commented Mar 11, 2024

No description provided.

@ioans73
Copy link
Member Author

ioans73 commented Mar 23, 2024

@tien-ld @rvalyi could you review this? It's the same as OCA/sale-workflow#3021

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ioans73
Copy link
Member Author

ioans73 commented Apr 11, 2024

@rvalyi Can it be merged?

@ioans73
Copy link
Member Author

ioans73 commented Apr 22, 2024

@pedrobaeza since it's approved, could you merge? Thanks

@pedrobaeza pedrobaeza added this to the 16.0 milestone Apr 22, 2024
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1680-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 82ba3a7 into OCA:16.0 Apr 22, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 79b5beb. Thanks a lot for contributing to OCA. ❤️

@ioans73 ioans73 deleted the 16.0-fix_account_invoice_fixed_discount_division_by_zero branch April 22, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants