[14.0][FIX] connector_importer: skip_fields_unchanged #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @simahawk, |
raumschmiede-joshuaL
force-pushed
the
14.0-fix-skip_fields_unchanged
branch
from
2a9d9ce
to
952d043
Compare
|
Shall I update the module version? |
raumschmiede-joshuaL
changed the title
this will be done by bot on merge |
simahawk
reviewed
Jun 27, 2024
| for k, v in current_values.items(): | ||
| if values[k] != v: | ||
| # FIXME: New value can be "1" and existing 1. Needs field conversion |
There was a problem hiding this comment.
We should probably use field's convert_to_read w/ use_name_get=False
simahawk
reviewed
Jun 27, 2024
| @@ -71,3 +71,31 @@ def test_find_domain(self): | |||
| self.assertEqual( | |||
| domain, [("name", "=", values["name"]), ("age", "=", values["age"])] | |||
| ) | |||
|
|
|||
| def test_odoo_write_purge_values(self): | |||
There was a problem hiding this comment.
thanks for adding a test! 🤝
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
skip_fields_unchangedis set for the record handler, the behaviour comparing existing with new values raises an error becausereadreturns a list and another one, thatidis not invalues.And the operator is wrong. Currently it would import the values only if they are the same as the existing.
I added a FIXME for later to convert the new values. Is this ok?