[MIG] connector_importer_source_sftp: Migration to 16.0 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-tombez
force-pushed
the
16.0-mig-connector_importer_source_sftp
branch
3 times, most recently
from
4914e5c
to
d8a7499
Compare
simahawk
reviewed
Sep 2, 2024
| @@ -1 +1,2 @@ | |||
| odoo-test-helper | |||
| mock | |||
There was a problem hiding this comment.
this is not needed. Just change the import of mock to from unittest import mock 😉
There was a problem hiding this comment.
It IS needed because this depends on storage_backend_sftp, which also requires mock.
See https://github.com/OCA/connector-interfaces/actions/runs/10612682197/job/29414865086#step:8:209
There was a problem hiding this comment.
it is NOT because that's broken there too. It has been migrated in the wrong way. There's no need for such dep. Trust me 😉
There was a problem hiding this comment.
There you go OCA/storage#388
A file can be moved only if we have a destination path.
Instead of throwing an exception with an unclear message in the _get_line function
simahawk
force-pushed
the
16.0-mig-connector_importer_source_sftp
branch
from
d8a7499
to
b72af96
Compare
|
FTR I couldn't replicate the failing test on the event listener locally Looks weird because the selection option should be already there. |
|
Ok. it fails only if you run tests at db creation. |
They must run at post_install to make sure the new source type is registered.
Fixes:
```
odoo.tests.suite: ERROR: setUpClass (odoo.addons.connector_importer_source_sftp.tests.test_event_listener.TestRecordImporterFinishedEvent)
Traceback (most recent call last):
File "/__w/connector-interfaces/connector-interfaces/connector_importer_source_sftp/tests/test_event_listener.py", line 25, in setUpClass
cls.recordset.write(
File "/opt/odoo-venv/lib/python3.10/site-packages/odoo/addons/component_event/models/base.py", line 109, in write
result = super(Base, self).write(vals)
File "/opt/odoo/odoo/models.py", line 3784, in write
field.write(self, value)
File "/opt/odoo/odoo/fields.py", line 1125, in write
cache_value = self.convert_to_cache(value, records)
File "/opt/odoo/odoo/fields.py", line 2735, in convert_to_cache
raise ValueError("Wrong value for %s: %r" % (self, value))
ValueError: Wrong value for import.recordset.source_model: 'import.source.csv.sftp'
```
|
Great, this change 876c609 fixed tests locally but not here 😓 |
|
I added a PR to update the dependency: p-tombez#1 |
IMP connector_importer_product update cryptography dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: BSALLO-1566