Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] fieldservice_portal: Migration to 16.0 #1224

Open
wants to merge 3 commits into
base: 16.0
Choose a base branch
from

Conversation

anusriNPS
Copy link

MIgrating fieldservice_portal to 16.0 version

@anusriNPS anusriNPS marked this pull request as draft October 15, 2024 15:20
@anusriNPS anusriNPS force-pushed the 16.0-mig-fieldservice_portal branch 2 times, most recently from 34469f2 to ff69dce Compare October 15, 2024 15:37
@max3903 max3903 added this to the 16.0 milestone Oct 16, 2024
@max3903 max3903 self-assigned this Oct 16, 2024
@max3903
Copy link
Member

max3903 commented Oct 16, 2024

/ocabot migration fieldservice_portal

@max3903 max3903 changed the title [16.0] [MIG] fieldservice portal: Migration to 16.0 [16.0][MIG] fieldservice_portal: Migration to 16.0 Oct 16, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 16, 2024
48 tasks
@anusriNPS anusriNPS marked this pull request as ready for review October 16, 2024 10:24
Copy link

@PicchiSeba PicchiSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: minor fixes in the views

<em class="font-weight-normal text-muted">
Work Orders for
<t
t-esc="searchbar_groupby[groupby]['label']"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t-esc has been deprecated in 15.0 in favour of t-out

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<tr>
<td>
<a t-attf-href="/my/workorder/#{order.id}">
<t t-esc="order.name" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

</a>
</td>
<td>
<t t-esc="order.description" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

</td>
<td>
<t
t-esc="order.sudo().location_id.display_name"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

/>
</td>
<td>
<t t-esc="order.type.name" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<t t-esc="order.type.name" />
</td>
<td>
<t t-esc="order.stage_id.name" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

</div>
<div class="col-md-6">
<strong>Stage:</strong>
<t t-esc="order.stage_id.name" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<t t-else="">Work Orders</t>
</li>
<li t-if="fsm_order" class="breadcrumb-item active">
<t t-esc="fsm_order.name" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@anusriNPS
Copy link
Author

Verified views after using t-out instead of t-esc and all are intact

@PicchiSeba
Copy link

We might need to add some tests, the coverage is quite low.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants