-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] fieldservice_portal: Migration to 16.0 #1224
base: 16.0
Are you sure you want to change the base?
Conversation
34469f2
to
ff69dce
Compare
/ocabot migration fieldservice_portal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review: minor fixes in the views
<em class="font-weight-normal text-muted"> | ||
Work Orders for | ||
<t | ||
t-esc="searchbar_groupby[groupby]['label']" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
t-esc
has been deprecated in 15.0 in favour of t-out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
<tr> | ||
<td> | ||
<a t-attf-href="/my/workorder/#{order.id}"> | ||
<t t-esc="order.name" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
</a> | ||
</td> | ||
<td> | ||
<t t-esc="order.description" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
</td> | ||
<td> | ||
<t | ||
t-esc="order.sudo().location_id.display_name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
/> | ||
</td> | ||
<td> | ||
<t t-esc="order.type.name" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
<t t-esc="order.type.name" /> | ||
</td> | ||
<td> | ||
<t t-esc="order.stage_id.name" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
</div> | ||
<div class="col-md-6"> | ||
<strong>Stage:</strong> | ||
<t t-esc="order.stage_id.name" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
<t t-else="">Work Orders</t> | ||
</li> | ||
<li t-if="fsm_order" class="breadcrumb-item active"> | ||
<t t-esc="fsm_order.name" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
ff69dce
to
a3405a4
Compare
Verified views after using t-out instead of t-esc and all are intact |
We might need to add some tests, the coverage is quite low. |
MIgrating fieldservice_portal to 16.0 version