[IMP] l10n_it_asset_management: Generate Code from Sequence

OCA · Oct 18, 2024 · 0de6329 · 0de6329
1 parent 4fec0ad
commit 0de6329
Show file tree

Hide file tree

Showing 7 changed files with 92 additions and 2 deletions.
diff --git a/l10n_it_asset_management/models/asset.py b/l10n_it_asset_management/models/asset.py
@@ -31,6 +31,9 @@ def get_default_company_id(self):
     code = fields.Char(
         default="",
     )
+    code_sequence_id = fields.Many2one(
+        related="category_id.code_sequence_id",
+    )
 
     company_id = fields.Many2one(
         "res.company",
@@ -114,6 +117,9 @@ def create(self, vals_list):
             asset = super().create(vals)
             if create_deps_from_categ:
                 asset.onchange_category_id()
+            code_sequence = asset.code_sequence_id
+            if code_sequence and not asset.code:
+                asset.code = code_sequence.next_by_id()
             assets |= asset
         return assets
 

diff --git a/l10n_it_asset_management/models/asset_category.py b/l10n_it_asset_management/models/asset_category.py
@@ -94,6 +94,11 @@ def get_default_type_ids(self):
         " printing assets' reports.",
     )
 
+    code_sequence_id = fields.Many2one(
+        comodel_name="ir.sequence",
+        help="Sequence to generate the Code of new assets.",
+    )
+
     tag_ids = fields.Many2many(
         "asset.tag",
         string="Tag",

diff --git a/l10n_it_asset_management/tests/test_assets_management.py b/l10n_it_asset_management/tests/test_assets_management.py
@@ -731,3 +731,22 @@ def test_same_asset_report_residual_partial_depreciation(self):
         self.assertEqual(
             asset_report_depreciation_line.amount_residual, expected_residual_amount
         )
+
+    def test_create_category_code_sequence(self):
+        """If the category has a "Code Sequence",
+        it is used for created assets."""
+        # Arrange
+        category = self.asset_category_1
+        sequence = self.env["ir.sequence"].create(
+            {
+                "name": "Test Sequence",
+            }
+        )
+        sequence_next = sequence.number_next
+        category.code_sequence_id = sequence
+
+        # Act
+        asset = self._create_asset()
+
+        # Assert
+        self.assertEqual(asset.code, str(sequence_next))
diff --git a/l10n_it_asset_management/views/asset.xml b/l10n_it_asset_management/views/asset.xml
@@ -82,7 +82,37 @@
                                 name="category_id"
                                 attrs="{'readonly': [('state', '!=', 'non_depreciated')]}"
                             />
-                            <field name="code" />
+                            <field
+                                name="code"
+                                attrs="{
+                                    'invisible': [
+                                        '&amp;',
+                                            ('code_sequence_id', '!=', False),
+                                            ('id', '=', False),
+                                    ],
+                                }"
+                            />
+                            <!-- Invisibility domain of `code_sequence_details` could be simpler,
+                            but like this it is easier to maintain and more obvious that it is
+                            the opposite of `code`'s invisibility domain. -->
+                            <div
+                                name="code_sequence_details"
+                                class="text-muted"
+                                colspan="2"
+                                attrs="{
+                                    'invisible': [
+                                        '!',
+                                            '&amp;',
+                                                ('code_sequence_id', '!=', False),
+                                                ('id', '=', False),
+                                    ],
+                                }"
+                            >
+                                The Code will be generated from the Category's Code Sequence <field
+                                    name="code_sequence_id"
+                                    class="d-inline"
+                                />
+                            </div>
                             <field
                                 name="used"
                                 attrs="{'readonly': [('state', '!=', 'non_depreciated')]}"

diff --git a/l10n_it_asset_management/views/asset_category.xml b/l10n_it_asset_management/views/asset_category.xml
@@ -69,6 +69,7 @@
                     <group>
                         <group>
                             <field name="tag_ids" widget="many2many_tags" />
+                            <field name="code_sequence_id" />
                         </group>
                         <group>
                             <field name="print_by_default" />

diff --git a/l10n_it_asset_management/wizard/account_move_manage_asset.py b/l10n_it_asset_management/wizard/account_move_manage_asset.py
@@ -33,6 +33,9 @@ def get_default_move_ids(self):
     code = fields.Char(
         default="",
     )
+    code_sequence_id = fields.Many2one(
+        related="category_id.code_sequence_id",
+    )
 
     company_id = fields.Many2one(
         "res.company",

diff --git a/l10n_it_asset_management/wizard/account_move_manage_asset_view.xml b/l10n_it_asset_management/wizard/account_move_manage_asset_view.xml
@@ -73,7 +73,33 @@
                                 options="{'no_create': True}"
                                 attrs="{'required': [('management_type', '=', 'create')]}"
                             />
-                            <field name="code" />
+                            <field
+                                name="code"
+                                attrs="{
+                                    'invisible': [
+                                        ('code_sequence_id', '!=', False),
+                                    ],
+                                }"
+                            />
+                            <!-- Invisibility domain of `code_sequence_details` could be simpler,
+                            but like this it is easier to maintain and more obvious that it is
+                            the opposite of `code`'s invisibility domain. -->
+                            <div
+                                name="code_sequence_details"
+                                class="text-muted"
+                                colspan="2"
+                                attrs="{
+                                    'invisible': [
+                                        '!',
+                                            ('code_sequence_id', '!=', False),
+                                    ],
+                                }"
+                            >
+                                The Code will be generated from the Category's Code Sequence <field
+                                    name="code_sequence_id"
+                                    class="d-inline"
+                                />
+                            </div>
                             <field name="used" />
                         </group>
                         <group>