[16.0] [FIX] l10n_it_reverse_charge: consider original invoice date in RC invoice comments #4142
Conversation
There was a problem hiding this comment.
Grazie della PR!
Puoi aggiungere un test? Magari ti basta aggiungere un assert a un test esistente.
Puoi modificare il messaggio del commit per seguire https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message? In particolare:
please check if the commit message is cut with ellipsis
| date=self.date, | ||
| date=reference_date, | ||
| internal_reference=self.name, |
There was a problem hiding this comment.
Se il riferimento interno è di self, mi aspetto che anche la data venga presa da self: quindi secondo me la scelta sta tra self.date e self.invoice_date (da decidere in #4141 (comment)).
Una volta scelto si potrebbe anche chiarire nel testo della descrizione quale delle due date è riportata.
rlucia
force-pushed
the
fix/narration-original-invoice-date
branch
3 times, most recently
from
d02725d
to
a3cf3ad
Compare
SirAionTech
added
the
needs fixing
|
/ocabot rebase |
For some unknown reason, since its inception (? OCA@e460d4d ) the description relating to the original invoice, always used the date of the RC document, not the actual one.
|
Congratulations, PR rebased to 16.0. |
OCA-git-bot
force-pushed
the
fix/narration-original-invoice-date
branch
from
fd1b1f4
to
288ac14
Compare
For some unknown reason, since its inception (? e460d4d ) the description relating to the original invoice, always used the date of the RC document, not the actual one.
Fixes: #4141