Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] l10n_it_sct_cbi #4367

Open
wants to merge 7 commits into
base: 14.0
Choose a base branch
from
Open

[14.0][MIG] l10n_it_sct_cbi #4367

wants to merge 7 commits into from

Conversation

toita86
Copy link

@toita86 toita86 commented Sep 10, 2024 •
edited
Loading

Backport of #4189 that depends on OCA/bank-payment#1344

added the backport of #4379

@toita86 toita86 marked this pull request as ready for review September 10, 2024 08:30
@toita86 toita86 mentioned this pull request Sep 10, 2024
Merged
@francesco-ooops
Copy link
Contributor

/ocabot migration l10n_it_sepa_bonifici

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Sep 13, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 13, 2024
Open
74 tasks
@toita86 toita86 force-pushed the 14.0-MIG-l10n_it_sct_cbi-toita86 branch from 4785ca6 to 6bd9793 Compare September 13, 2024 08:43
@SirAionTech
Copy link
Contributor

Sto correggendo un problema nel modulo 16.0 in #4379, probabilmente sarà da includere anche qui

MaurizioConte
MaurizioConte suggested changes Sep 26, 2024
View reviewed changes
Copy link

@MaurizioConte MaurizioConte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

da un test effettuato il file generato contiene il tag ReqdExctnDt che ha un tag **<Dt/>** che non è corretto è un di più che non ci deve essere infatti correggendo la stringa sul file e ripassando per il controllo sul sito CBI funziona.

<ReqdExctnDt><Dt>2024-09-26</Dt><Dt/></ReqdExctnDt>

@francesco-ooops
Copy link
Contributor

da un test effettuato il file generato contiene il tag ReqdExctnDt che ha un tag **<Dt/>** che non è corretto è un di più che non ci deve essere infatti correggendo la stringa sul file e ripassando per il controllo sul sito CBI funziona.

<ReqdExctnDt><Dt>2024-09-26</Dt><Dt/></ReqdExctnDt>

@SirAionTech ti risulta anche sulla v16 questo problema?

@SirAionTech
Copy link
Contributor

da un test effettuato il file generato contiene il tag ReqdExctnDt che ha un tag **<Dt/>** che non è corretto è un di più che non ci deve essere infatti correggendo la stringa sul file e ripassando per il controllo sul sito CBI funziona.
<ReqdExctnDt><Dt>2024-09-26</Dt><Dt/></ReqdExctnDt>

@SirAionTech ti risulta anche sulla v16 questo problema?

I file prodotti da #4189 erano validi

su https://www.cbiservice.com/correttoresepa.php, selezionando l'opzione: SCT - CBIBdyPaymentRequest 00.04.01 (new).

Non so se si sta parlando di un altro controllo o se magari si riproduce solo con certi passi, se devo verificarlo secondo me servono più info.

@MaurizioConte
Copy link

MaurizioConte commented Sep 27, 2024 via email

MaurizioPellegrinet
MaurizioPellegrinet approved these changes Oct 8, 2024
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test funzionale: OK

MaurizioConte
MaurizioConte approved these changes Oct 8, 2024
View reviewed changes
Copy link

@MaurizioConte MaurizioConte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test OK

@francesco-ooops
Copy link
Contributor

@SirAionTech si può mergiare?

aleuffre
aleuffre reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: LGTM. Però mi sembra che i test non vengano eseguiti, puoi verificare?

@francesco-ooops
Copy link
Contributor

/ocabot rebase

SirAionTech and others added 4 commits October 16, 2024 09:21
@SirAionTech @OCA-git-bot
[MIG] l10n_it_sepa_bonifici: Migration to 16.0
a81e1b6 
Use new standards
Added namespace to pain descendants
IBAN is mandatory
Initiating party is mandatory
FinInstd/Othr is not allowed
ReqdExctnDt has new structure
BICFI in PaymentRequest instead of BIC
Manage multiple priorities
Added test
Updated README
Updated translations
@OCA-git-bot
[UPD] Update l10n_it_sct_cbi.pot
2559433
@OCA-git-bot
[BOT] post-merge updates
0336194
@weblate @OCA-git-bot
Update translation files
72fd9d0 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_sct_cbi
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_sct_cbi/
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 14.0.

@OCA-git-bot OCA-git-bot force-pushed the 14.0-MIG-l10n_it_sct_cbi-toita86 branch from 14df0d6 to 20fac5d Compare October 16, 2024 09:21
@toita86 toita86 force-pushed the 14.0-MIG-l10n_it_sct_cbi-toita86 branch from 20fac5d to 6fcf603 Compare October 21, 2024 08:13
@SirAionTech SirAionTech added the needs fixing Has conflicts or is failing mandatory CI checks label Oct 21, 2024
@toita86 toita86 force-pushed the 14.0-MIG-l10n_it_sct_cbi-toita86 branch from 6fcf603 to f05f170 Compare October 21, 2024 14:01
@SirAionTech SirAionTech removed the needs fixing Has conflicts or is failing mandatory CI checks label Oct 21, 2024
aleuffre
aleuffre reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tutto il resto mi sembra ok, ho solo un dubbio su uno degli ultimi cambiamenti.

l10n_it_sct_cbi/tests/test_generate_file.py
Comment on lines +113 to +114
if None in namespaces:
namespaces["default"] = namespaces.pop(None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Non sono sicuro di questa aggiunta (e l'analoga qualche riga sotto)

@SirAionTech cosa ne pensi?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non so se un find con questi nuovi namespaces possa trovare i tag del namespace incriminato (namespaces[None]), però è anche vero che per ora vengono solo cercati i tag nel namespace PMRQ quindi il test per ora credo sia rimasto valido

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confermo che in locale i test passano anche senza questa modifica. Se non da problemi sulle pipeline OCA, sarei per rimuoverlo.

Per info, nel test test_multiple_payment_priority la variabile namespaces contiene questo:

{
    None: 'urn:CBI:xsd:CBIBdyPaymentRequest.00.04.01', 
    'PMRQ': 'urn:CBI:xsd:CBIPaymentRequest.00.04.01'
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleuffre aleuffre aleuffre left review comments

@SirAionTech SirAionTech SirAionTech left review comments

@MaurizioConte MaurizioConte MaurizioConte approved these changes

@MaurizioPellegrinet MaurizioPellegrinet MaurizioPellegrinet approved these changes

Assignees
No one assigned
Labels
14.0 approved migration
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
8 participants
@toita86 @francesco-ooops @SirAionTech @MaurizioConte @OCA-git-bot @aleuffre @MaurizioPellegrinet @weblate