Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] l10n_it_central_journal_reportlab: escape Paragraph content #4400

Merged
merged 1 commit into from
Oct 18, 2024
Merged

[16.0][FIX] l10n_it_central_journal_reportlab: escape Paragraph content #4400

merged 1 commit into from
Oct 18, 2024

Conversation

TheMule71
Copy link
Contributor

Paragraph() prende un simil-HTML, un markup con varie direttive tipo <para> ecc.

passandogli dei dati, meglio fare l'escape di tutto.

Fixes: #4396
Fixes: #4153

@OCA-git-bot
Copy link
Contributor

Hi @Borruso, @MarcoCalcagni,
some modules you are maintaining are being modified, check this out!

This was referenced Oct 11, 2024
Open
Open
Draft
@francesco-ooops
Copy link
Contributor

@TheMule71 la #4153 risulta già fixata per la 16, non è così?

@TheMule71
Copy link
Contributor Author

@TheMule71 la #4153 risulta già fixata per la 16, non è così?

Si ma era estremamente parziale, solo per un campo e solo per i caratteri '<' e '>'.

Il problema si ripropone potenzialmente su altri campi e per altri caratteri (per es. prob interpreta & e &) ecc.

La mia fix dovrebbe essere generica, usa una libreria XML per fare l'escape delle direttive, e la applico su tutti i valori che sono potenzialmente dinamici (non prefissati nei sorgenti).

@francesco-ooops francesco-ooops mentioned this pull request Oct 11, 2024
Open
2 tasks
Borruso
Borruso approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@Borruso Borruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@MarcoCalcagni puoi mergiare

@MarcoCalcagni
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-4400-by-MarcoCalcagni-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d47afea into OCA:16.0 Oct 18, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 11b63c5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borruso Borruso Borruso approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
5 participants
@TheMule71 @OCA-git-bot @francesco-ooops @MarcoCalcagni @Borruso