Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

git pre-commit hook doesn't ignore installable=False modules #286

Closed
pedrobaeza opened this issue Oct 22, 2015 · 6 comments
Closed

git pre-commit hook doesn't ignore installable=False modules #286

pedrobaeza opened this issue Oct 22, 2015 · 6 comments

Comments

@pedrobaeza
Copy link
Member

@moylop260, is there a way to avoid to check non installable modules?

@moylop260
Copy link
Contributor

Oh yes, I have next pending

@moylop260
Copy link
Contributor

@pedrobaeza
I didn't saw the error that your comment here.
I changed a module to installable=False and executed pre-commit script
and it wasn't checked.

Could you explain better the real scenario to reproduce the issue?
(git clone, apply change (diff file), commands executed, you saw, you
expected)

Moisés López Calderón
Vauxoo - OpenERP's Gold Partner
Mobile: (+521) 477-752-22-30
Office: (+52) 477-773-33-46
web: http://www.vauxoo.com
twitter: @Vauxoo
@moylop260
hangout: [email protected]

@pedrobaeza
Copy link
Member Author

It happens on flake8 checks, not pylint, but all unported modules that violate these checks, doesn't allow to continue the commit.

@moylop260
Copy link
Contributor

Flake8 dont support just-in-changed and installable=False in git hook... Just pylint checks

@dreispt
Copy link
Member

dreispt commented Nov 7, 2015

Maybe it's time to drop flake8...

@pedrobaeza
Copy link
Member Author

I close this one to let #292 as main request for avoiding this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants