Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Drop flake8? #292

Closed
dreispt opened this issue Nov 6, 2015 · 9 comments
Closed

Drop flake8? #292

dreispt opened this issue Nov 6, 2015 · 9 comments

Comments

@dreispt
Copy link
Member

dreispt commented Nov 6, 2015

MQT currently uses two tools for linting, flake8 and pylint, and I see people puzzled at why the complexity.
Indeed this is so for historical reasons (pylint was added only later in the game), but at the moment I feel that pylint is capable of doing everything and more that flake8 can.

So I propose to move the existing flake8 checks to pylint checks, and remove the flake8 dependency from MQT.

@pedrobaeza
Copy link
Member

If pylint can do everything, why not?

@moylop260
Copy link
Contributor

+1

1 similar comment
@elicoidal
Copy link
Contributor

+1

@moylop260
Copy link
Contributor

@dreispt
Do you have a plan of work in this issue?

@dreispt
Copy link
Member Author

dreispt commented Feb 11, 2016

@moylop260 I'm sorry but no - in the little time I will have I will give priority to a few new modules I'm in need.

@moylop260
Copy link
Contributor

I got it
Thank you.
I will use the help wanted label.

@pedrobaeza
Copy link
Member

pedrobaeza commented Oct 12, 2016

As mentioned in #286, this would also allow to ignore non installable modules.

@nhomar
Copy link
Member

nhomar commented Oct 30, 2017

I was talking with @moylop260 and even pylint team delegate some work to Flake8.

This will be simplified on the move on #500 and future work, can I close this issue?

@moylop260
Copy link
Contributor

The pylint’s maintainer recommend us use both tools:
pylint-dev/pylint#1110 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants