This repository has been archived by the owner on May 16, 2024. It is now read-only.
[REF] has_test_errors: Detect error if there is a traceback in the log #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moylop260
force-pushed
the
oca-fix-false-green-moy
branch
from
c8219ad
to
2182c33
Compare
|
Not sure this is a good idea, as I remember to see some tracebacks that are catched by a try and tested, and then they shouldn't go red. |
|
assertRaises or/and odoo.tools.mute_logger is the solution for those kind of tests |
|
I see right now this one: https://travis-ci.org/OCA/server-tools/jobs/525558942#L1635 My point is that this will turn red some branches. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #600
Similar to runbot regex where
Tracebackis detected as error: