Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] gen_addon_readme: text regarding OCA sponsoring program #468

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

legalsylvain
Copy link
Contributor

add a simple text to promote sponsoring program of the OCA. Feel free to change / improve / fix typo editing directly the PR.

CC : @OCA/board

Copy link
Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedrobaeza
Copy link
Member

The only problem on this is that it will be a lot of commits for updating whole OCA repos, saturating Travis/runbot, so this should be planned on advance.

@legalsylvain
Copy link
Contributor Author

Hi @pedrobaeza . Thanks for your suggestion. I applied it.

The only problem on this is that it will be a lot of commits for updating whole OCA repos, saturating Travis/runbot, so this should be planned on advance.

We can just accept this PR, update OCA bot, and then, wait that natural PR (migration / patch) update the readme of modules. No need to update all the modules quickly, I think.

Or did I miss something ?

@dreispt
Copy link
Member

dreispt commented Sep 10, 2020

Can't these updates be incremental, as PRs are merged and individual READMES rebuilt with them?

@pedrobaeza
Copy link
Member

There's a cron in OCA server to update all READMEs of all repos, which is great, as you can synchronize any change. The only cons is that it should be planned as said.

@legalsylvain
Copy link
Contributor Author

There's a cron in OCA server to update all READMEs of all repos, which is great, as you can synchronize any change. The only cons is that it should be planned as said.

Thanks for the explanation.

@dreispt
Copy link
Member

dreispt commented Sep 10, 2020

@pedrobaeza Does it make sense to drop the cron in favor of a precommit task?

@pedrobaeza
Copy link
Member

Well, it was done for avoiding manual interventions or rely on contributors for that synchronization, but you can tell @sbidoul that was the one that did it.

@legalsylvain
Copy link
Contributor Author

Any chance to have this PR accepted ?

IMO, it's a pity not to promote ways to support the OCA financially, on the OCA modules.

@rousseldenis
Copy link
Contributor

@OCA/core-maintainers

@rousseldenis
Copy link
Contributor

@legalsylvain Could you rebase ?

@legalsylvain
Copy link
Contributor Author

rebased.
tests are failing. don't understand why. Any idea ?

@rousseldenis
Copy link
Contributor

rebased. tests are failing. don't understand why. Any idea ?

Look into test:

image

@sbidoul sbidoul changed the title [ADD] text regarding OCA sponsoring program [ADD] gen_addon_readme: text regarding OCA sponsoring program Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants