Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][ADD] mis_builder_analytic_query #308

Closed

Conversation

sergiocorato
Copy link

Thanks for your pull request. Please take a moment to review if it meets the following
guidelines.

Description

Before coding, it is recommended to create an issue to discuss the problem or feature
you want to add. If you did not, don't worry, we can discuss on the PR too.

If there is a pre-existing issue that your PR implements or fixes, add a pointer to it
in the PR description.

If your PR is simple enough that it does not require a preliminary discussion, then make
sure to explain what it does (i.e. why the change is necessary).

Test

Don't forget to add unit tests. If your PR fixes a bug, prefer creating a separate
commit for the test so we one see that your test reproduces the bug and is fixed by the
PR.

Target branch

MIS Builder is actively maintained for Odoo versions 9, 10, 11 and 12.

If your feature is applicable with the same implementation to all these versions, please
target branch 10.0. Maintainers will port it to 9, 11 and 12 soon after merging.

In the rare cases your feature or implementation is specific to an Odoo version, then
target the corresponding branch.

CLA

Have you signed the OCA Contributor License Agreement? If not, please visit
https://odoo-community.org/page/cla to learn how.

Changelog entry

This projects uses towncrier to generate it's
changelog. Make sure your PR includes a changelog entry in
<addon>/readme/newsfragments/. It must have the issue or PR number as name, and one of
.feature, .bugfix, .doc (for documentation improvements), .misc (if a ticket has
been closed, but it is not of interest to users). The changelog entry must be reasonably
short and phrased in a way that is understandable by end users.

Documentation

Consider improving the documention in docs/.

@sergiocorato sergiocorato force-pushed the 12.0-add-mis_builder_analytic_query branch 3 times, most recently from e3b0dd0 to da204d3 Compare August 27, 2020 15:48
@pedrobaeza
Copy link
Member

Is this similar to OCA/mis-builder-contrib#6 ?

@sergiocorato sergiocorato force-pushed the 12.0-add-mis_builder_analytic_query branch from da204d3 to ff74633 Compare August 27, 2020 16:07
@sergiocorato
Copy link
Author

sergiocorato commented Aug 27, 2020

Is this similar to OCA/mis-builder-contrib#6 ?

In no way, this one add the ability to filter the queries on other object (like repair.line, purchase.order.line, etc) by the same analytic account of account.move.line

@sergiocorato sergiocorato force-pushed the 12.0-add-mis_builder_analytic_query branch from ff74633 to 7ee1cee Compare August 27, 2020 16:13
@sergiocorato sergiocorato force-pushed the 12.0-add-mis_builder_analytic_query branch from 7ee1cee to cc765a3 Compare August 28, 2020 09:26
@sbidoul
Copy link
Member

sbidoul commented Aug 28, 2020

@sergiocorato thanks for this!

As is it should rather go to https://github.com/oca/mis-builder-contrib, could you move the PR over there?

That said, it's a feature that is sometimes requested and that I'd like to bring into the core at some point (#309).
I'm not sure about the best UX to configure that.

@sergiocorato
Copy link
Author

@sergiocorato thanks for this!

As is it should rather go to https://github.com/oca/mis-builder-contrib, could you move the PR over there?

That said, it's a feature that is sometimes requested and that I'd like to bring into the core at some point (#309).
I'm not sure about the best UX to configure that.

I saw that this was a missing feature, I tried to resolve it in a simply way. I'll move the PR.

@sergiocorato
Copy link
Author

Moved to OCA/mis-builder-contrib#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants