Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] mis_builder: Filter period by company #575

Closed
wants to merge 1 commit into from

Conversation

etobella
Copy link
Member

Implements #183 inside the core

@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

Copy link

@JoanSForgeFlow JoanSForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGMT 👍

@sbidoul
Copy link
Member

sbidoul commented Oct 30, 2023

LGTM. This must not be ported beyond 15 because in 16, the analytic domain covers the use case, is that correct?

@etobella
Copy link
Member Author

You are right @sbidoul It seems easier to configure, but it is not necessary

@sbidoul
Copy link
Member

sbidoul commented Oct 30, 2023

BTW, we had backport part of the analytic domain feature to 14 in #565.

@etobella
Copy link
Member Author

In this case, we can remove this PR. WDYT?

@sbidoul
Copy link
Member

sbidoul commented Oct 30, 2023

As you prefer, either we keep it (and forward port it) if you think an easier mechanism is necessary for company filters, or we remove it.

@etobella
Copy link
Member Author

With the new mechanism it is not needed, so I would recommend to refuse it

@etobella etobella closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants