Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This pull request implements the following features: Adding a quarter period type Improved fiscal period . Fixes #622 . #643

Open
wants to merge 6 commits into
base: 17.0
Choose a base branch
from

Conversation

collokip169
Copy link

Thanks for your pull request. Please take a moment to review if it meets the following
guidelines.

Description

Before coding, it is recommended to create an issue to discuss the problem or feature
you want to add. If you did not, don't worry, we can discuss on the PR too.

If there is a pre-existing issue that your PR implements or fixes, add a pointer to it
in the PR description.

If your PR is simple enough that it does not require a preliminary discussion, then make
sure to explain what it does (i.e. why the change is necessary).

Test

Don't forget to add unit tests. If your PR fixes a bug, prefer creating a separate
commit for the test so we one see that your test reproduces the bug and is fixed by the
PR.

Target branch

MIS Builder is actively maintained for Odoo versions 9, 10, 11 and 12.

If your feature is applicable with the same implementation to all these versions, please
target branch 10.0. Maintainers will port it to 9, 11 and 12 soon after merging.

In the rare cases your feature or implementation is specific to an Odoo version, then
target the corresponding branch.

CLA

Have you signed the OCA Contributor License Agreement? If not, please visit
https://odoo-community.org/page/cla to learn how.

Changelog entry

This projects uses towncrier to generate it's
changelog. Make sure your PR includes a changelog entry in
<addon>/readme/newsfragments/. It must have the issue or PR number as name, and one of
.feature, .bugfix, .doc (for documentation improvements), .misc (if a ticket has
been closed, but it is not of interest to users). The changelog entry must be reasonably
short and phrased in a way that is understandable by end users.

Documentation

Consider improving the documention in docs/.

@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

@collokip169 collokip169 marked this pull request as draft October 15, 2024 06:08
@collokip169
Copy link
Author

Hi @sbidoul, some modules you are maintaining are being modified, check this out!

okay

@collokip169
Copy link
Author

okay

@collokip169 collokip169 marked this pull request as ready for review October 15, 2024 08:14
@collokip169 collokip169 marked this pull request as draft October 15, 2024 08:14
@collokip169 collokip169 marked this pull request as ready for review October 15, 2024 08:15
@collokip169
Copy link
Author

@thomaspaulb could you please review this when you have time?

@thomaspaulb
Copy link

This pull request implements the following features:

This needs to be in the description of the PR, you can edit it there and remove this

@thomaspaulb
Copy link

Please also fix pre-commit errors

image

@collokip169 collokip169 changed the title quarterly period This pull request implements the following features: Adding a quarter period type Improved fiscal period . Fixes #622 . Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants