[11.0][ADD] purchase_order_secondary_unit: New module to allow buy in secondary units #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmignon
reviewed
Oct 26, 2018
lmignon
suggested changes
Oct 26, 2018
purchase_order_secondary_unit/tests/test_purchase_order_secondary_unit.py
Outdated
Show resolved
Hide resolved
|
@sergio-teruel Can you also check travis. Some dependencies are missing |
sergio-teruel
force-pushed
the
11.0-PR_purchase_order_secondary_unit
branch
from
e3ccbca
to
c7ee647
Compare
|
@lmignon Thanks!!. Changes done. The tests will fails until the OCA/product-attribute#398 has not been merged. |
sergio-teruel
force-pushed
the
11.0-PR_purchase_order_secondary_unit
branch
from
c7ee647
to
7f3ccfd
Compare
tarteo
suggested changes
Oct 31, 2018
tarteo
suggested changes
Oct 31, 2018
|
@tarteo Are you referring to changing the name form "Secondary uom" to "Secondary product unit of measure"?.. I think that this name is very long.... 😲 |
|
@sergio-teruel Yes, just so it's consistent with the other label. |
|
@tarteo seems not a big issue, secondary uom sound good as well, isn't it? |
|
Ready to merge? |
rousseldenis
approved these changes
Nov 14, 2018
purchase_order_secondary_unit/tests/test_purchase_order_secondary_unit.py
Show resolved
Hide resolved
sergio-teruel
force-pushed
the
11.0-PR_purchase_order_secondary_unit
branch
from
7f3ccfd
to
9bdc268
Compare
tarteo
approved these changes
Dec 4, 2018
pedrobaeza
force-pushed
the
11.0-PR_purchase_order_secondary_unit
branch
from
9bdc268
to
454e4c8
Compare
|
@pedrobaeza @sergio-teruel Did this PR not depending on OCA/product-attribute#398 as announced ? |
|
Well, not technically, but for coherence for not seeing 2 times the same field. Sorry for not checking before. Can we merge the other already? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends of OCA/product-attribute#398
cc @Tecnativa