Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] queue_job: HA job runner using session level advisory lock #668

Open
wants to merge 4 commits into
base: 16.0
Choose a base branch
from
Open

[IMP] queue_job: HA job runner using session level advisory lock #668

wants to merge 4 commits into from

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Jul 2, 2024

Another attempt.

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@sbidoul sbidoul mentioned this pull request Jul 2, 2024
Closed
@sbidoul
[FIX] queue_job: close connection to databases without job queue
0a434d8 
Without this, we leak connections to Databases that don't have queue_job
installed.
@sbidoul
[FIX] queue_job: handle exceptions in Database constructor
e267d92 
Without this we risk connection leaks in case of exceptions in the
constructor.
@sbidoul
Copy link
Member Author

sbidoul commented Jul 2, 2024

Yep, this should work.

guewen
guewen approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@guewen guewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@sbidoul
Copy link
Member Author

sbidoul commented Jul 4, 2024

@PCatinean do you know who we should ping in the odoo.sh team to have an opinion on this approach?

@PCatinean
Copy link
Contributor

Hi @sbidoul the only two people I know around this topic are @amigrave which gave the initial feedback on the advisory lock MR here #256 and @sts-odoo which also provided some feedback on the pg_application_name approach

@sbidoul
Copy link
Member Author

sbidoul commented Jul 4, 2024

@amigrave @sts-odoo so the TL;DR here is that we have one long lived connection to the database on which we take a session-level advisory lock and do a LISTEN. There is no long-lived transaction, so this should not impact replication.

I plan to deploy this on a odoo.sh dev env soon to see how it goes. I can PM you the details if you which to monitor something.

@qgroulard qgroulard mentioned this pull request Jul 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guewen guewen guewen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbidoul @OCA-git-bot @PCatinean @guewen