[17.0][MIG] base_exception : Migration to 17.0 #2761

peluko00 · 2023-11-17T12:58:51Z

No description provided.

…lled by constraint methods 'detect_exception' can be called on an empty recordset.

- Show menu only to Exception Rule Managers - Use sequence and active widgets on tree view - Updated form to use sheet

… the _popup_exceptions mehtod

[IMP] Computed exception descriptions field, to display better help messages [IMP] Exceptions shouldn't be copied

By default exceptions can be ignored by the click of a button. Users begin human they will just click that button what ever the internal rules. So this PR adds the option to set specific exceptions as blocking. When exceptions are detected if one of them is blocking, the user will not be able to ignore them.

use odoo-test-helper split test so one test do one thing

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-base_exception Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_exception/

peluko00 · 2023-11-17T14:20:40Z

Module migrated to version 17.0

cc https://github.com/APSL 148520

@miquelalzanillas @lbarry-apsl @Javierbcn @samoros1 please review

Issue #2752

pedrobaeza · 2023-11-17T14:40:36Z

The "pre-commit fixes" commit is missing.

Check migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

/ocabot merge base_exception

pedrobaeza · 2023-11-17T14:41:50Z

/ocabot migration base_exception

peluko00 · 2023-11-17T14:46:59Z

The "pre-commit fixes" commit is missing.

Check migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

/ocabot merge base_exception

I squash the all migration's commits in one

pedrobaeza · 2023-11-17T14:49:16Z

But "pre-commit fixes" is not a "migration commit". It's something apart. I told you about squashing in other PR because you have up to 3 "[MIG] xxxx: Migration to 17.0" commits.

peluko00 · 2023-11-17T15:02:01Z

But "pre-commit fixes" is not a "migration commit". It's something apart. I told you about squashing in other PR because you have up to 3 "[MIG] xxxx: Migration to 17.0" commits.

I understand Pedro, sorry for the mistake. It's okay now?

pedrobaeza · 2023-11-17T15:17:06Z

No worries, Antoni, it's a process to fully get into OCA that gets some time.

Coming again to this PR, it seems the order and the content is not the proper one. Maybe it's better to redo the migration, saving your final files before doing it, so you don't have also to redo the migration itself.

peluko00 · 2023-11-20T09:57:59Z

No worries, Antoni, it's a process to fully get into OCA that gets some time.

Coming again to this PR, it seems the order and the content is not the proper one. Maybe it's better to redo the migration, saving your final files before doing it, so you don't have also to redo the migration itself.

I go back to first commit when initialize the project and now i commited all i one. Much better?

pedrobaeza · 2023-11-20T18:44:25Z

base_exception/readme/CONTRIBUTORS.md

@@ -0,0 +1,15 @@
+- Raphaël Valyi \<\<<[email protected]>\>\>


@sbidoul seems that this conversion to MD is not correct, putting extra <.

Is this entire thing just hanging on correcting this, and if so can I fix it?

pedrobaeza · 2023-11-20T18:45:10Z

The "pre-commit fixes" commit is still missing, but let's not be nitpicking.

/ocabot migration base_exception

nguyenminhchien · 2023-12-15T08:42:17Z

base_exception/models/base_exception.py

-                            )
+                        f"<li>{html.escape(e.name)}: <i>{html.escape(e.description or '')}</i> <b>"
+                        + _(
+                            "{'(Blocking exception)' if e.is_blocking else ''}</b></li>"


string format error

Try: f"{'(Blocking exception)' if e.is_blocking else ''}</b></li>"

nguyenminhchien · 2023-12-15T08:44:58Z

base_exception/models/exception_rule.py

        return res

    def write(self, vals):
        res = super().write(vals)
-        self._get_cached_rules_for_domain.clear_cache(self)
+        self._get_cached_rules_for_domain.cache.clear(self)


i face this warning:

File "/home/chien/code/odoo/odoo/17.0/odoo/models.py", line 4960, in _load_records_write self.write(values) File "/home/chien/code/oca/server-tools/17.0/base_exception/models/exception_rule.py", line 132, in write self._get_cached_rules_for_domain.cache.clear(self) File "/home/chien/code/odoo/odoo/17.0/odoo/tools/cache.py", line 113, in clear warnings.warn('Deprecated method ormcache.clear(model, *args), use registry.clear_cache() instead')

I'm facing this warning too

As far as I know, using this for create, write and unlink should be the correct way now:

self.env.registry.clear_cache()

Hi @nguyenminhchien, may you check this #2809 ?

nguyenminhchien · 2023-12-15T08:46:46Z

base_exception/views/base_exception_view.xml

@@ -69,7 +71,7 @@
                        <page
                            name="help"
                            string="Help"
-                            attrs="{'invisible': [('exception_type','!=','by_py_code')]}"
+                            invisible="exception_type != 'by_py_code'"


the view is broken

nguyenminhchien · 2023-12-15T08:53:21Z

base_exception/static/description/index.html

I face this warning:
DeprecationWarning: XML declarations in HTML module descriptions are deprecated since Odoo 17, base_exception can just have a UTF8 description with not need for a declaration..

It's better if we remove the first line: <?xml version="1.0" encoding="utf-8"?>
You could also fetch this commit: OCA/maintainer-tools@8f89ec4 to let pre-commit does its things.

I'm facing this warning too

john-herholz-dt · 2024-01-08T14:38:03Z

@peluko00 are you still working on it?
Kind regards

nguyenminhchien · 2024-01-17T10:12:32Z

base_exception/wizard/base_exception_confirm_view.xml

+                <footer>
+                    <button
+                        name="action_confirm"
+                        string="_Close"


I believe "_Close" is a typo.

gurneyalex · 2024-02-02T07:46:59Z

Merged in #2809

mourad-ehm and others added 30 commits November 17, 2023 11:11

[ADD] split module sale_exception into base_exception

8c1d0c3

[FIX] base_exception: '_check_exception' is 'api.multi' since it's ca…

f938eb1

…lled by constraint methods 'detect_exception' can be called on an empty recordset.

[MIG] base_exception: Migration to 11.0

b5f622c

[FIX] temp model test access rule & fix OCA remarks

6c30411

[FIX] Enable post_install for tests + pylint

420764e

[IMP] Update base_exception views

13b4eed

- Show menu only to Exception Rule Managers - Use sequence and active widgets on tree view - Updated form to use sheet

FIX remove old api parameters in base_exception

0d4ed28

[FIX] base_exception: send the active_model in the conxtext when call…

34a110b

… the _popup_exceptions mehtod

[MIG] base_exception: Migration to 12.0

82ffdb2

[WIP] sale_exception_by_domain

eb08679

FIX self[0] in _rule_group

4cd9da7

[MIG] dict.iteritems() does not exist in Python3

bf9dfc4

[IMP] Add convenience action to ignore exceptions on record

34b5d12

[IMP] Computed exception descriptions field, to display better help messages [IMP] Exceptions shouldn't be copied

[IMP] base_exception: black, isort

0ef4c2e

[MIG] base_exception: Migration to 13.0

da31985

[UPD] Update base_exception.pot

60fcd76

[IMP] base_exception: black, isort, prettify

fb76ad1

[14.0][MIG] base_exception: Migration to 14.0

ca0f7f5

[UPD] README.rst

43e355e

[FIX] fix access right

eca55e3

[FIX] base_exception: import correctly osv.expression

48f58ae

[14.0][FIX] base_exception, error if rule's description is null

6bd4d7b

[UPD] Update base_exception.pot

92668b9

[IMP] base_exception: Allow to skip exception checks through context

0ceaca5

[13.0][fix][base_exception] search only active exception rules

411bb82

[IMP] base_exception: test blocking exceptions

8b7974d

[IMP] add method exception

ad001fb

[REF] Refactor test

66216bc

use odoo-test-helper split test so one test do one thing

[IMP] base_exception: log traceback when code exception is raised

d235ac5

OCA-git-bot and others added 3 commits November 17, 2023 11:11

base_exception 16.0.2.0.0

d104808

[UPD] README.rst

22f41c8

Update translation files

710f8e5

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-base_exception Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_exception/

peluko00 mentioned this pull request Nov 17, 2023

Migration to version 17.0 #2752

Open

34 tasks

peluko00 force-pushed the 17.0-mig-base_exception branch from efa2710 to f3a1ee4 Compare November 17, 2023 14:32

OCA deleted a comment from OCA-git-bot Nov 17, 2023

OCA-git-bot added this to the 17.0 milestone Nov 17, 2023

peluko00 closed this Nov 17, 2023

peluko00 reopened this Nov 17, 2023

peluko00 force-pushed the 17.0-mig-base_exception branch from 8a545ed to 2c5e51b Compare November 17, 2023 14:56

[MIG] base_exception: Migration to 17.0

bc734e6

peluko00 force-pushed the 17.0-mig-base_exception branch from 5452215 to bc734e6 Compare November 20, 2023 09:54

pedrobaeza reviewed Nov 20, 2023

View reviewed changes

nguyenminhchien suggested changes Dec 15, 2023

View reviewed changes

nguyenminhchien mentioned this pull request Dec 18, 2023

[17.0][MIG] sale_exception: Migration to 17.0 OCA/sale-workflow#2860

Merged

nguyenminhchien reviewed Jan 17, 2024

View reviewed changes

sonhd91 mentioned this pull request Jan 23, 2024

[MIG] purchase_exception: Migrate to version 17.0 OCA/purchase-workflow#2154

Merged

OCA-git-bot mentioned this pull request Feb 2, 2024

[17.0][MIG] base_exception: Migration to 17.0 #2809

Merged

gurneyalex closed this Feb 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] base_exception : Migration to 17.0 #2761

[17.0][MIG] base_exception : Migration to 17.0 #2761

peluko00 commented Nov 17, 2023

peluko00 commented Nov 17, 2023 •

edited

Loading

pedrobaeza commented Nov 17, 2023

pedrobaeza commented Nov 17, 2023

peluko00 commented Nov 17, 2023 •

edited

Loading

pedrobaeza commented Nov 17, 2023

peluko00 commented Nov 17, 2023 •

edited

Loading

pedrobaeza commented Nov 17, 2023

peluko00 commented Nov 20, 2023

pedrobaeza Nov 20, 2023

jaredkipe Dec 5, 2023

pedrobaeza commented Nov 20, 2023

nguyenminhchien Dec 15, 2023

nguyenminhchien Dec 15, 2023

astirpe Jan 2, 2024

john-herholz-dt Jan 15, 2024

lef-adhoc Jan 17, 2024

nguyenminhchien Dec 15, 2023

nguyenminhchien Dec 15, 2023

lef-adhoc Jan 8, 2024

john-herholz-dt commented Jan 8, 2024

nguyenminhchien Jan 17, 2024

gurneyalex commented Feb 2, 2024

		@@ -0,0 +1,15 @@
		- Raphaël Valyi \<\<<[email protected]>\>\>

[17.0][MIG] base_exception : Migration to 17.0 #2761

[17.0][MIG] base_exception : Migration to 17.0 #2761

Conversation

peluko00 commented Nov 17, 2023

peluko00 commented Nov 17, 2023 • edited Loading

pedrobaeza commented Nov 17, 2023

pedrobaeza commented Nov 17, 2023

peluko00 commented Nov 17, 2023 • edited Loading

pedrobaeza commented Nov 17, 2023

peluko00 commented Nov 17, 2023 • edited Loading

pedrobaeza commented Nov 17, 2023

peluko00 commented Nov 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Nov 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

john-herholz-dt commented Jan 8, 2024

Choose a reason for hiding this comment

gurneyalex commented Feb 2, 2024

peluko00 commented Nov 17, 2023 •

edited

Loading

peluko00 commented Nov 17, 2023 •

edited

Loading

peluko00 commented Nov 17, 2023 •

edited

Loading