Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] survey_question_type_binary #89

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

zamberjo
Copy link
Member

@zamberjo zamberjo commented Jul 14, 2023

New module that enables the option to upload files in the surveys, controlling both the type of file uploaded and its size.
It also adds the possibility of adding several files with the option "Multiple: Binary".

@zamberjo zamberjo force-pushed the ADD/survey_question_type_binary branch 5 times, most recently from 8921c08 to 2c64e92 Compare July 17, 2023 09:02
@zamberjo zamberjo marked this pull request as ready for review July 17, 2023 09:05
@zamberjo
Copy link
Member Author

Pre-commit is fixed with #90.

@zamberjo zamberjo marked this pull request as draft July 17, 2023 09:49
@zamberjo zamberjo force-pushed the ADD/survey_question_type_binary branch from 2c64e92 to 2b221d3 Compare July 17, 2023 12:03
@zamberjo zamberjo marked this pull request as ready for review July 17, 2023 12:03
@zamberjo zamberjo force-pushed the ADD/survey_question_type_binary branch from 2b221d3 to dd88dd6 Compare July 17, 2023 17:38
@zamberjo zamberjo changed the title [ADD][14.0] survey_question_type_binary [14.0][ADD] survey_question_type_binary Jul 17, 2023
@zamberjo zamberjo force-pushed the ADD/survey_question_type_binary branch from dd88dd6 to 2f99b0c Compare July 17, 2023 17:56
@zamberjo zamberjo force-pushed the ADD/survey_question_type_binary branch from 2f99b0c to 5c83a0f Compare July 17, 2023 18:54
Copy link

@belenaures belenaures left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked to see if I could upload correctly more than 1 image in a binary question, works ok

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-89-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command git push origin 14.0-ocabot-merge-pr-89-by-pedrobaeza-bump-nobump:14.0 failed with output:

To https://github.com/OCA/survey
 ! [rejected]        14.0-ocabot-merge-pr-89-by-pedrobaeza-bump-nobump -> 14.0 (fetch first)
error: failed to push some refs to 'https://***@github.com/OCA/survey'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

@OCA-git-bot OCA-git-bot merged commit 291682e into OCA:14.0 Aug 21, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fe9d076. Thanks a lot for contributing to OCA. ❤️

@zamberjo zamberjo deleted the ADD/survey_question_type_binary branch August 23, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants