-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][IMP] webservice: add support for oauth2 authentication #41
base: 15.0
Are you sure you want to change the base?
Conversation
Hi @etobella, |
ab05ccf
to
29f624c
Compare
see also #35 |
Allow using oauth2 with Backend Application Flow / Client Credentials Grant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG. The fix on the onchange has to be back/fwd ported? If yes, I'd recommend splitting it in its own commit.
The use of a compute method on `oauth2_flow` when this field is touched by the server environment mixin causes it to be defined twice as computed, with differents settings, and this ultimately causes a warning message in the logs: ``` WARNING odoo odoo.modules.registry: webservice.backend: inconsistent 'compute_sudo' for computed fields: protocol, url, auth_type, username, password, api_key, api_key_header, oauth2_flow, oauth2_clientid, oauth2_client_secret, oauth2_token_url, oauth2_authorization_url, oauth2_audience, oauth2_scope, content_type ``` We fix this by using an old fashioned onchange declaration on the `auth_type` field.
You are right. Forward ported to 16. 0 on #47 by the way |
No description provided.