"Fix" PERFORM bounds check in 4.x - but disable it for now as it is not ISO-compliant #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddeclerck
changed the title
GitMensch
requested changes
Oct 21, 2024
ddeclerck
force-pushed
the
gc4_index_check_tweaks
branch
2 times, most recently
from
b964c7f
to
bf523b0
Compare
GitMensch
requested changes
Oct 22, 2024
ddeclerck
force-pushed
the
gc4_index_check_tweaks
branch
from
bf523b0
to
2ae8aa8
Compare
|
I guess that's it ? |
ddeclerck
force-pushed
the
gc4_index_check_tweaks
branch
from
2ae8aa8
to
8de1114
Compare
GitMensch
approved these changes
Oct 23, 2024
|
Thanks again - time for upstream trunk, then going on with the 3x->trunk merge. It would be nice if you find the time to finish #191 by backporting this adjustment (which then has a misleading title). |
Actually I might as well add a ChangeLog entry for those changes (especially those in
I'll add those changes to #191 but I'll let someone else deal with the "other stuff" that remain to be addressed in that PR.
Well at first it was just about disabling the PEFORM bound check, hence the title. |
ddeclerck
force-pushed
the
gc4_index_check_tweaks
branch
from
8de1114
to
5c503a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #147 (comment).