Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coupon code can be used on multiple carts #992

Open
RickAcb opened this issue Jan 23, 2023 · 1 comment
Open

Coupon code can be used on multiple carts #992

RickAcb opened this issue Jan 23, 2023 · 1 comment
Milestone

Comments

@RickAcb
Copy link
Contributor

RickAcb commented Jan 23, 2023

Currently coupon codes can be used on multiple carts and checked out to make a coupon code used more than the allowed usage.

We found 2 options to solve this:

1. Use the coupon on adding on the cart and remove them from carts after a certain amount
Pro: Carts and checkout will provide correct information on the website
Cons: Coupon codes will say that they are used but are not really used

  1. Recheck if the coupon was still able to be used when creating the order from the cart
    Pro: Allows the coupon to be used more then allowed amount in carts but not in order
    Cons: Price can suddenly be changed on ordering if the coupon was used, this can make customer complain

We made a PR to solve it on the first option but it can also be solved on 2nd or other way.

@RickAcb
Copy link
Contributor Author

RickAcb commented Mar 3, 2023

I recommend that a solution is found for on the 2nd option by adding an extra check in the DB Transaction for creating the order to make absolutely sure that the coupon would still work.

We might pick this up to create a PR about it later but at this moment we don't have time to create it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants