Change coupon code usage on cart and removing coupon codes from carts #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please don't merge yet we found some issues with this. @xyzqtc will provide some updates later this week on it. |
|
This PR should not be merged as it will not work in the current flow of OFFLINE Mall, see comment on #992 |
|
Thank you for updating the PR @RickAcb! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is possible to add coupon codes see issue #992 Coupon code can be used on multiple carts .
We have changed the usage on the shopping cart after adding the coupon code.
The coupon is removed from carts every hour once the cart is between 6-10 hours old to make sure the coupon code is ready for usage on other carts.