Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[setting] 스타일 가이드 수정사항 반영 #125

Merged
merged 4 commits into from
Jul 6, 2024
Merged

[setting] 스타일 가이드 수정사항 반영 #125

merged 4 commits into from
Jul 6, 2024

Conversation

mmaybei
Copy link
Member

@mmaybei mmaybei commented Jul 5, 2024

🔗 연결된 이슈

📄 작업 내용

  • 변경된 스타일 가이드에 따라 컬러 에셋을 수정 및 삭제, 추가하였습니다!
  • 추가된 텍스트 스타일(tittle00, label00)에 따라 UIFont+ 익스텐션을 수정하였습니다!
  • 진웅오빠의 의견에 따라, UILabel+ 익스텐션의 setText 함수의 텍스트 컬러를 black으로 디폴트 지정하였습니다!

@mmaybei mmaybei added ⚙️ setting 프로젝트 관련 설정 변경 시 사용 ❤️ SuYeon 무한 잼얘 지옥에 빠지고 싶다면 labels Jul 5, 2024
@mmaybei mmaybei self-assigned this Jul 5, 2024
@mmaybei mmaybei linked an issue Jul 5, 2024 that may be closed by this pull request
[setting] 스타일 가이드 수정사항 반영 #123
Closed
3 tasks
JinUng41
JinUng41 approved these changes Jul 6, 2024
View reviewed changes
Copy link
Contributor

@JinUng41 JinUng41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.
다만, label00의 경우 leading 값이 138%이기 때문에, 해당 내용이 코드에 반영되어야 할 것 같습니다.
확인 부탁드릴게요~

hooni0918
hooni0918 approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@hooni0918 hooni0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

역시 최고의 개발자 김수연 정말 멋져~~~

youz2me
youz2me approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@youz2me youz2me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
최고의 개발자 김수연! 고생하셨습니다 ~~!

@mmaybei mmaybei merged commit 8d463c9 into suyeon Jul 6, 2024
1 check passed
@JinUng41 JinUng41 deleted the setting/#123-extensionChange branch July 6, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youz2me youz2me youz2me approved these changes

@JinUng41 JinUng41 JinUng41 approved these changes

@hooni0918 hooni0918 hooni0918 approved these changes

Assignees

@mmaybei mmaybei

Labels
⚙️ setting 프로젝트 관련 설정 변경 시 사용 ❤️ SuYeon 무한 잼얘 지옥에 빠지고 싶다면
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[setting] 스타일 가이드 수정사항 반영
4 participants
@mmaybei @youz2me @JinUng41 @hooni0918