Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Auth네트워크 Request, Response Model 구현 #141

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

hooni0918
Copy link
Member

응답, 요청 값 작성완료

🔗 연결된 이슈

📄 작업 내용

  • Auth 네트워크 모델 작성

@hooni0918 hooni0918 added ✨ feat 기능 구현시 사용 🧡 JiHoon 쌈뽕한 플러팅 꿀팁을 듣고 싶다면 labels Jul 8, 2024
@hooni0918 hooni0918 self-assigned this Jul 8, 2024
@hooni0918 hooni0918 linked an issue Jul 8, 2024 that may be closed by this pull request
1 task
@hooni0918 hooni0918 changed the title feat/#134 - Auth네트워크 Request, Response Model 구현 [feat] /#134 - Auth네트워크 Request, Response Model 구현 Jul 8, 2024
Copy link
Contributor

@JinUng41 JinUng41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR 컨벤션 안 지키는 상습범!
주의해 주세요!

Comment on lines 9 to 13

// MARK: - SocialLoginRequestModel
struct SocialLoginResponseModel: Codable {
let name, accessToken, refreshToken: String?
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마크 주석 코딩 컨벤션 지켜주세요!

Comment on lines 9 to 13

// MARK: - ResissueResponseModel
struct ResissueResponseModel: Codable {
let accessToken, refreshToken: String?
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resissue가 뭔지 모르겠네요.. 설명 부탁드립니다.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reissue 입니다 감사합니다

@hooni0918 hooni0918 changed the title [feat] /#134 - Auth네트워크 Request, Response Model 구현 [feat] Auth네트워크 Request, Response Model 구현 Jul 8, 2024
Copy link
Member

@mmaybei mmaybei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 ~!

@hooni0918 hooni0918 removed the request for review from chanubc July 8, 2024 12:23
Copy link
Member

@youz2me youz2me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 리뷰 반영 부탁드려용 ~~!

import Foundation


// MARK: - SocialLoginRequestModel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마크는 Request로 되어있어용 ...

import Foundation


// MARK: - ReissueResponseModel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

개행해주세요!

Copy link
Member

@youz2me youz2me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생~~~!!!!

@hooni0918 hooni0918 merged commit 0cc781a into suyeon Jul 8, 2024
@hooni0918 hooni0918 deleted the feat/#134-authService branch July 8, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feat 기능 구현시 사용 🧡 JiHoon 쌈뽕한 플러팅 꿀팁을 듣고 싶다면
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Auth네트워크 Request, Response Model 구현
4 participants