[fix] 1차 QA 반영 #364
Merged
[fix] 1차 QA 반영 #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
JinUng41
approved these changes
Sep 4, 2024
Comment on lines
+119
to
+148
| if let moveTime = formatter.date(from: moveStartTime.value) { | ||
| let calendar = Calendar.current | ||
|
|
||
| let moveTimeComponents = calendar.dateComponents([.hour, .minute], from: moveTime) | ||
| let currentTimeComponents = calendar.dateComponents([.hour, .minute], from: Date()) | ||
|
|
||
| if let moveHour = moveTimeComponents.hour, let moveMinute = moveTimeComponents.minute, | ||
| let currentHour = currentTimeComponents.hour, let currentMinute = currentTimeComponents.minute { | ||
| if currentHour > moveHour || (currentHour == moveHour && currentMinute > moveMinute) { | ||
| self.isLate.value = true | ||
| } else { | ||
| self.isLate.value = false | ||
| } | ||
| } | ||
| } | ||
| case .ready: | ||
| if let readyTime = formatter.date(from: readyStartTime.value) { | ||
| let calendar = Calendar.current | ||
|
|
||
| let readyTimeComponents = calendar.dateComponents([.hour, .minute], from: readyTime) | ||
| let currentTimeComponents = calendar.dateComponents([.hour, .minute], from: Date()) | ||
|
|
||
| if let readyHour = readyTimeComponents.hour, let readyMinute = readyTimeComponents.minute, | ||
| let currentHour = currentTimeComponents.hour, let currentMinute = currentTimeComponents.minute { | ||
| if currentHour > readyHour || (currentHour == readyHour && currentMinute > readyMinute) { | ||
| self.isLate.value = true | ||
| } else { | ||
| self.isLate.value = false | ||
| } | ||
| } |
There was a problem hiding this comment.
공통되는 부분은 메서드로 분리할 수 있을 것 같아요.
'DRY'라고 'Don't Repeat Yourself'인데, 개발 시 동일한 코드를 반복하지 말라라는 뜻입니다.
Comment on lines
+99
to
+100
| viewModel.promiseInfo.bindOnMain(with: self) { owner, model in | ||
| owner.rootView.myReadyStatusProgressView.isUserInteractionEnabled = (model?.isParticipant ?? false) |
| // MARK: - UICollectionViewDelegateFlowLayout | ||
|
|
||
| extension PromiseInfoViewController: UICollectionViewDelegateFlowLayout { | ||
| func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, sizeForItemAt indexPath: IndexPath) -> CGSize { |
There was a problem hiding this comment.
이 부분은 메서드가 너무 길기 때문에 개행해도 좋을 것 같네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 연결된 이슈
📄 작업 내용
👀 기타 더 이야기해볼 점