Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-hide does not hide the button for path_selector #3425

Closed
Tracked by #3393
johrstrom opened this issue Mar 14, 2024 · 4 comments · Fixed by #3460
Closed
Tracked by #3393

data-hide does not hide the button for path_selector #3425

johrstrom opened this issue Mar 14, 2024 · 4 comments · Fixed by #3460
Assignees
Labels
bug Existing functionality not working as expected component/batch_connect
Milestone

Comments

@johrstrom
Copy link
Contributor

johrstrom commented Mar 14, 2024

initially reported on discourse - https://discourse.openondemand.org/t/cluster-specific-modules-dont-populate-in-form-yml-erb/3287/20

I haven't replicated yet, but I'm sure it's real.

@osc-bot osc-bot added this to the Backlog milestone Mar 14, 2024
@johrstrom johrstrom added component/batch_connect bug Existing functionality not working as expected labels Mar 14, 2024
@johrstrom johrstrom modified the milestones: Backlog, 4.0, 3.1 Mar 14, 2024
@HazelGrant HazelGrant self-assigned this Mar 21, 2024
@HazelGrant
Copy link
Contributor

Can reproduce with this form.yml:

form:
  - dir1
  - dir2
  - hide
attributes:
  hide:
    widget: 'select'
    options: 
      - ['hide dir1', 'hide dir1', data-hide-dir1: true]
      - ['hide dir2', 'hide dir2', data-hide-dir2: true]
  dir1:
    widget: "path_selector"
  dir2:
    widget: "path_selector"

@johrstrom
Copy link
Contributor Author

Can reproduce with this form.yml:

It's the Select Path button that we also need to hide. I just tried with that form and could reproduce. The text input is hidden, but not the button to Select Path.

@HazelGrant
Copy link
Contributor

There's more to this. data-hide-* fails for radio_button and file_attachments as well.

form:
  - dir1
  - dir2
  - hide
  - radio_test
  - hide_radio
  - attachments_test
  - hide_attachments
attributes:
  hide:
    widget: 'select'
    options: 
      - ['hide dir1', 'hide dir1', data-hide-dir1: true]
      - ['hide dir2', 'hide dir2', data-hide-dir2: true]
  dir1:
    widget: "path_selector"
  dir2:
    widget: "path_selector"
  radio_test:
    widget: "radio_button"
    value: "1"
    options:
      - ["one", 1]
      - ["zero", 0]
  hide_radio:
    widget: "select"
    options:
      - [ 'show radio', 'show radio']
      - [ 'hide radio', 'hide radio', data-hide-radio-test: true]
  attachments_test:
    widget: "file_attachments"
  hide_attachments:
    widget: "select"
    options:
      - ["show attachments", "show attachments"]
      - ["hide attachments", "hide attachments", data-hide-attachments-test: true]
Screen.Recording.2024-03-26.at.9.41.29.AM.mov

@johrstrom
Copy link
Contributor Author

There's more to this. data-hide-* fails for radio_button and file_attachments as well.

OK, I think we should solve this for path_selector first, if we can catch the others, great, if not then we'll create more tickets and defer the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality not working as expected component/batch_connect
Projects
None yet
3 participants