Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

associate job log with project, not launchers #3707

Closed
Tracked by #3394
johrstrom opened this issue Aug 1, 2024 · 0 comments · Fixed by #3740
Closed
Tracked by #3394

associate job log with project, not launchers #3707

johrstrom opened this issue Aug 1, 2024 · 0 comments · Fixed by #3740
Assignees
Milestone

Comments

@johrstrom
Copy link
Contributor

johrstrom commented Aug 1, 2024

There's something wrong here that I think I started. jobs are associated with the launchers and that's why you have to do all this weirdness here. But I think a better/simpler paradigm really is that the project itself keeps the job log and the entries have a relationship to the launcher (if we even need such a relationship).

Which is really just to say that I think we should rethink & refactor this whole paradigm before it gets worse. I think we can move forward with this as it is, but will likely have to change it almost immediately.

Originally posted by @johrstrom in #3702 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants