refactor how jobs are logged in the project manager #3740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashton22305
reviewed
Aug 23, 2024
Comment on lines
+6
to
+10
| stored_job = existing_jobs.detect { |j| j.id == job.id && j.cluster == job.cluster } | ||
|
|
||
| if stored_job.nil? | ||
| new_jobs = (existing_jobs + [job.to_h]).map(&:to_h) | ||
| else |
There was a problem hiding this comment.
It looks like completed jobs are not being saved with clusters, which is causing there to be duplicate entries in the job log that appear to never load in the projects#show page.
There was a problem hiding this comment.
Thanks for checking! I thought there was something buggy here but couldn't quite put my finger on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor how jobs are logged in the project manager
Fixes #3707 by adding a module to take care of updating these log files. Of course this moves the log file location so it breaks current jobs which is fine because this is still beta.