Added POLL_DELAY environment variable to UserConfiguration class #3421
Conversation
|
I'm not sure if it should be a profile based thing. Generally folks want to control this so that |
|
I always tend to add all properties to the UserConfiguration class to make them available in profiles and, in this case, because it already supports ENV variables. Will move it to the main Configuration object. |
abujeda
force-pushed
the
3413_poll_delay
branch
from
71a2c83
to
3107f1f
Compare
|
Moved to Configuration object. |
| def sessions_poll_delay | ||
| poll_delay = ENV['POLL_DELAY'] | ||
| poll_delay.nil? ? config.fetch(:sessions_poll_delay, '10000') : poll_delay.to_s | ||
| end |
There was a problem hiding this comment.
I have a couple things here.
First can we prepend bc_ to this. That'll follow other configuration names so folks can see they all relate to batch_connect.
Secondly - I'm thinking we need some sort of check like casting to_i to be sure it's an integer. I also think that 10000 should be the default and likely minimum too. I'd hate to see someone configure 1 and just blow up their system lol.
There was a problem hiding this comment.
Yes, that is better. I completed the updates
abujeda
force-pushed
the
3413_poll_delay
branch
from
3107f1f
to
5346f13
Compare
abujeda
force-pushed
the
3413_poll_delay
branch
from
5346f13
to
470a756
Compare
Added POLL_DELAY environment variable to UserConfiguration class.
This change is backwards compatible with the environment variable.
Fixes #3413