Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flash button after upgrade to Bootstrap 5 #3592

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Conversation

ashton22305
Copy link
Contributor

fixes #3591

Changed data-dismiss to data-bs-dismiss to restore functionality.

Changed close to btn-close and removed span elements with &times to update buttons appearances to Bootstrap 5. The alignment still doesn't look quite right though:
image

@ashton22305
Copy link
Contributor Author

Adding alert-dismissible to the flashes fixed the alignment:
image
Tests need updated though in order to account for Bootstrap using SVGs for the close button instead of a character.

Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@johrstrom johrstrom merged commit 174eef3 into master Jun 11, 2024
23 checks passed
@johrstrom johrstrom deleted the fix-bootstrap-flash branch June 11, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't close flash and it's visually different
3 participants