Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.1.8 #3779

Merged
merged 8 commits into from
Sep 17, 2024
Merged

3.1.8 #3779

merged 8 commits into from
Sep 17, 2024

Conversation

johrstrom
Copy link
Contributor

Here are a bunch of things we need to backport to 3.1. They're all bug fixes or optimizations.

johrstrom and others added 8 commits September 5, 2024 10:39
Hide download buttons for certain files like pipes or files that aren't readable.
Convert data to human sizes on the client so that the server can respond faster.
Fix downloadable? to account for other file types like block devices.
Account for more than just \w for usernames which can have all sorts of characters.
* fixes #3728 with solution provided by httpd devs

* use base uri and let httpd set the query parameters
completed the fix of the issue #3730
* Handle remote uploads as file transfers

Apache expects a response to the request within 60 seconds
(ProxyTimeout). Avoid that by responding with a transfer for the upload,
which the browser will query the status of instead.

* Explicitly close RemoteTransfer tempfile

Prevents the Tempfile from staying around until garbage collection on
error.
Copy link
Contributor

@ashton22305 ashton22305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@johrstrom johrstrom merged commit f2b3cbb into release_3.1 Sep 17, 2024
26 checks passed
@johrstrom johrstrom deleted the 3.1.8 branch September 17, 2024 13:15
@CSC-swesters
Copy link
Contributor

Thanks for backporting these! Do you plan to tag a release 3.1.8 and package it soon? We're interested in deploying it as soon as it's ready. Or is there something which is still pending that I've missed?

@johrstrom
Copy link
Contributor Author

There is something pending that I'm working on this week.

@CSC-swesters
Copy link
Contributor

Got it, thanks. If the timelines align, Robin's optimization in #3804 would be a nice backport candidate too, once it's reviewed and accepted.

@johrstrom
Copy link
Contributor Author

Got it, thanks. If the timelines align, Robin's optimization in #3804 would be a nice backport candidate too, once it's reviewed and accepted.

I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants