Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for the closest anchor when trying to open a link #3923

Merged
merged 1 commit into from
Nov 5, 2024
Merged

check for the closest anchor when trying to open a link #3923

merged 1 commit into from
Nov 5, 2024

Conversation

johrstrom
Copy link
Contributor

Fixes #3803 because the event.target was actually the span which does not have an href. So this checks for the closest anchor (a) that has the event.target as a child.

@johrstrom johrstrom merged commit 5ec1821 into master Nov 5, 2024
26 checks passed
@johrstrom johrstrom deleted the fix-dashboard-links branch November 5, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component/dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

external links on dashboard index don't work
2 participants
@johrstrom @osc-bot