-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove runtime dependency on SCL #3952
Conversation
Also remove references to SCL Apache Fixes #3904
@johrstrom Do you know of any other places where we do |
How does Also doesn't apache do something here to load the environment? |
This is how SCL knows where to find:
I think it then looks for
So rather than doing
I don't think so, at least not anymore.
That We only need SCL enable to load OnDemand's things. Since SCL is no longer used to load Ruby or NodeJS or Apache, SCL at this time is only used to initialize the OnDemand environment for things like finding gems. |
I'm leaving as draft while I verify with local package builds that doing |
Local build appears successful: Setup steps:
Install has no
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I'm happy to just move on it and see how it goes in dev. I also looked for apache's loading the environment and couldn't find it anymore.
There are other spots where we look for X_SCL
environment variables, but it should be ok just given they don't exist anymore.
@johrstrom For OSC dev we'll need to uninstall |
Thanks. I saw you synced the repos too, I don't always remember to do that. |
Also remove references to SCL Apache
Fixes #3904