Skip to content

Commit

Permalink
vnc: run websockify as background process
Browse files Browse the repository at this point in the history
Instead of running as a daemon, making websockify run as a background
process. This ensures that the process gets cleaned up property if and
when job is terminated. With certain job schedulers/environments
(e.g. OpenPBS+AzHOP), this avoids dangling processes lingering post job
termination.
  • Loading branch information
utkarshayachit committed Jul 31, 2023
1 parent e003521 commit 508ed2c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/ood_core/batch_connect/templates/vnc.rb
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def after_script
echo "Starting websocket server..."
websocket=$(find_port)
[ $? -eq 0 ] || clean_up 1 # give up if port not found
#{websockify_cmd} -D ${websocket} localhost:${port}
#{websockify_cmd} ${websocket} localhost:${port} &
# Set up background process that scans the log file for successful
# connections by users, and change the password after every
Expand Down

0 comments on commit 508ed2c

Please sign in to comment.