Fixed misc warnings #4208
Merged
Fixed misc warnings #4208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string "PJ_DATUMS_" is nowhere else in the codebase, so presumably it is leftover junk.
The warning was: warning: cast from 'unsigned char *' to 'int *' increases required alignment from 1 to 4 [-Wcast-align] An idiomatic solution is to use memcpy().
This function is unused when building with ENABLE_TIFF=OFF. The warning was: warning: unused function template 'insertIntoHierarchy' [-Wunused-template]
Only define _GNU_SOURCE on Cygwin. warning was: warning: macro is not used [-Wunused-macros]
Warnings were: warning: unused member function 'get_table' [-Wunused-member-function] warning: unused member function 'clear' [-Wunused-member-function] The string `get_table` appears nowhere else in the repository. The string `clear` does, being so generic, but things still compile after its removal, and these are tests, not public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small collection of warning fixes.