Fix parameter mappings of Local Orthographic, and re-import ESRI database with the mapping for this method #4229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base with the mapping for this method
| @@ -403,6 +403,11 @@ static const ParamMapping paramScaleFactorPseudoStdParallel = { | |||
| WKT1_SCALE_FACTOR, common::UnitOfMeasure::Type::SCALE, | |||
| k}; /* ignored by PROJ currently */ | |||
|
|
|||
| static const ParamMapping paramLongCentreLongCenter = { | |||
There was a problem hiding this comment.
is paramLongCentreLongCenter name "duplicated" in purpose? Using "Centre" and "Center"? Or the editor tricked you?
There was a problem hiding this comment.
paraLongCentreLongCenter is indeed a very badly named variable. I believe it intends to capture the (WKT2, WKT1) names, but they are actually here ("Longitude of origin", "longitude_of_center"). I remember to have struggled establishing those mappings because the same WKT2 parameter name doesn't always map to the same WKT1 parameter name, depending on which projection method it is used in. Partly because WKT1 parameter names were invented before, and/or EPSG had renamed them after they were hardcoded in GDAL 20 years ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @jjimenezshaw