added flag -c contributors logging #58
Open
+90
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehighestmath
commented
Sep 23, 2024
| contributor_name = contributor["author"]["login"] | ||
| total_commits = contributor["total"] | ||
| total_commits_dict[contributor_name] = total_commits | ||
| return total_commits_dict |
There was a problem hiding this comment.
добавить пустую строку
| if args.export_google_sheets: | ||
| export_sheets.write_data_to_table(csv_name, args.google_token, args.table_id, args.sheet_id) | ||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| main() | ||
|
|
There was a problem hiding this comment.
а тут убрать
| @@ -30,7 +30,10 @@ python3 main.py --invites [-t, --token] token (github токен вместо to | |||
| ```commandline | |||
| python3 main.py [-w, --wikis] [-t, --token] token (github токен вместо token) [-l, --list] list (list - строка пути к txt файлу со списком репозиториев) --dowland_repos path_drepo (path_drepo - строка пути к директории, где сохраняются вики-репозитории) [-o, --out] out (out - название csv файла, в который будут помещены все логи) | |||
| ``` | |||
|
|
|||
There was a problem hiding this comment.
может тут вернуть?
Comment on lines
+6
to
+9
| EMPTY_FIELD = 'Empty field' | ||
| TIMEDELTA = 0.05 | ||
| TIMEZONE = 'Europe/Moscow' | ||
| FIELDNAMES = ('repository name', 'login', 'name', 'email', 'url', 'permissions', 'total_commits', 'id', 'node_id', 'type', 'bio', 'site_admin') |
There was a problem hiding this comment.
в другом ПРе выносится это в отдельный файлик
главное потом не забыть вынести)
Comment on lines
+27
to
+41
| info_tmp = { | ||
| 'repository name': repository.full_name, | ||
| 'login': contributor.login, | ||
| 'name': nvl(contributor.name), | ||
| 'email': nvl(contributor.email), | ||
| 'url': contributor.html_url, | ||
| 'permissions': nvl(contributor_permissons), | ||
| 'total_commits': contributor_total_commits, | ||
| 'id': contributor.id, | ||
| 'node_id': contributor.node_id, | ||
| 'type': contributor.type, | ||
| 'bio': nvl(contributor.bio), | ||
| 'site_admin': contributor.site_admin, | ||
| } | ||
| log_contributors_to_csv(info_tmp, csv_name) |
There was a problem hiding this comment.
и такой подход планируется заменить на датаклассы
#54
Comment on lines
+67
to
+70
| while request.status_code == 202: | ||
| print("Waiting for response...") | ||
| sleep(10) | ||
| request = requests.get(request_name, headers=headers) |
There was a problem hiding this comment.
А что за код 202? почему мы его ретраим?
There was a problem hiding this comment.
Кажется лучше сделать какой-то порог по количеству ретраев и если не получилось за условные 5 попыток, то падать
Вечно ждать никто не будет :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#35
На всякий случай припасу способ, которым воспользовался. Ветку сломать дело несложное, но нужно впредь будет самому всё починить :)