Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prettify syntax in redis-sentiel,redis-cluster,redis-operator #75

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

genofire
Copy link
Contributor

@genofire genofire commented Feb 23, 2023

remove all the bad syntax:

  • eq .Values.externalConfig.enabled true
  • {{ if .a.b.c }}{{ .a.b.c}}{{ end }} -> {{ with .a.b.c }}{{ . }}{{ end }}
  • {{ range $key, $value }} -> {{ toYaml }}
  • nicer indent, with nindent and {{-

a first step before improve any logic ....

  • in redis-cluster just one servicemonitor ...

@genofire
Copy link
Contributor Author

rebased -> could anyone please merge it?
@shubham-cmyk ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant