Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exchange fee collection #89

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix exchange fee collection #89

wants to merge 2 commits into from

Conversation

peculiarity
Copy link
Contributor

No description provided.

adamskrodzki
adamskrodzki reviewed Nov 15, 2021
View reviewed changes
Copy link
Contributor

@adamskrodzki adamskrodzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, commented only on refactoring.

I'm missing clear test failing before and passing after

contracts/multiply/Exchange.sol Outdated
@@ -92,13 +92,20 @@ contract Exchange {
return balance;
}

function _collectFee(address asset, uint256 fromAmount) internal returns (uint256) {
function _collectFeeTokenToDai(address asset, uint256 fromAmount) internal returns (uint256) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since "asset" is allways DAI_ADDRESS in both invocation maybe it will be clearer to remove asset parameter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@peculiarity
Copy link
Contributor Author

Looks ok, commented only on refactoring.

I'm missing clear test failing before and passing after

What do you mean by that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamskrodzki adamskrodzki adamskrodzki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peculiarity @adamskrodzki