Ensure fee does not exceed fromAmount in swap contract

OasisDEX · Oct 16, 2024 · 8c8b6b5 · 8c8b6b5
1 parent 77f0636
commit 8c8b6b5
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/packages/dma-contracts/contracts/swap/Swap.sol b/packages/dma-contracts/contracts/swap/Swap.sol
@@ -133,12 +133,17 @@ contract Swap {
     uint256 fromAmount,
     uint256 fee
   ) internal returns (uint256 amount) {
-    amount = fromAmount.sub(fee);
-
+    // if fee gt fromAmount, fee should eq fromAmount
+    if (fee > fromAmount) {
+      fee = fromAmount;
+    }
+
     if (fee > 0) {
       IERC20(asset).safeTransfer(feeBeneficiaryAddress, fee);
       emit FeePaid(feeBeneficiaryAddress, fee, asset);
     }
+
+    amount = fromAmount.sub(fee);
   }
 
   function _collectFee(