Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][PATCH] Aave Close Bug #428

Merged
merged 2 commits into from
Aug 22, 2023
Merged

[FIX][PATCH] Aave Close Bug #428

merged 2 commits into from
Aug 22, 2023

Conversation

zerotucks
Copy link
Collaborator

Description of Changes

Please list the changes introduced by this PR:

  • Updated Close Multiply on AAVE to use shared/common helpers for determining swap data
  • Clean up remaining code in close strategy

How to Test

Please provide instructions on how to test the changes in this PR:

PR Definition of Done

Please ensure the following requirements have been met before marking the PR as ready for review:

  • All checks are passing
  • PR is linked to a corresponding ticket
  • PR title is clear and concise
  • Code has been self-reviewed and any fixes or improvements noted (See Code review standards in Notion)
  • Documentation has been updated if necessary

@codesandbox
Copy link

codesandbox bot commented Aug 22, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@zerotucks zerotucks merged commit ece017a into dev Aug 22, 2023
3 checks passed
@zerotucks zerotucks deleted the jt/fix-aave-close-to-coll branch August 22, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants