Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unwrap all WETH on erc4626 withdraw #650

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Conversation

halaprix
Copy link
Member

Ticket URL

Please provide a link to the ticket:

Description of Changes

Please list the changes introduced by this PR:

  • unwrap all eth in case it's a weth vault
  • skip one return funds action if the vault depositi token and the returned tokens are eth - so they can be handled in one action

How to Test

Please provide instructions on how to test the changes in this PR:

PR Definition of Done

Please ensure the following requirements have been met before marking the PR as ready for review:

  • All checks are passing
  • PR is linked to a corresponding ticket
  • PR title is clear and concise
  • Code has been self-reviewed and any fixes or improvements noted (See Code review standards in Notion)
  • Documentation has been updated if necessary

@halaprix
Copy link
Member Author

[sc-14926]

Copy link

This pull request has been linked to Shortcut Story #14926: [BUG] - ETH position - Cannot withdraw.

@halaprix halaprix merged commit eb795d2 into dev Mar 20, 2024
2 checks passed
@halaprix halaprix deleted the kk/fix-weth-close-erc4626 branch March 20, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants